chore: remove redundant @Repository annotations and upgrade Spring Boot to 4.1.0 - #6930
Open
Ludy87 wants to merge 19 commits into
Open
chore: remove redundant @Repository annotations and upgrade Spring Boot to 4.1.0#6930Ludy87 wants to merge 19 commits into
@Repository annotations and upgrade Spring Boot to 4.1.0#6930Ludy87 wants to merge 19 commits into
Conversation
dosubot
Bot
added
the
size:M
stirlingbot
Bot
added
Java
dosubot
Bot
added
size:L
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
Comment on lines
+25
to
+29
| + " p.teamId = :teamId) order by coalesce(p.sortOrder, 0) asc, p.id asc") | ||
| List<PolicyEntity> findByTeam(@Param("teamId") Long teamId); | ||
|
|
||
| /** All policies in run order — used when team scoping is off (login-disabled). */ | ||
| @Query("select p from PolicyEntity p order by coalesce(p.sortOrder, 0) asc, p.id asc") |
Contributor
There was a problem hiding this comment.
Query logic conflicts with its documented behavior: coalesce(p.sortOrder, 0) makes null and 0 equivalent, so null sortOrder rows are not guaranteed to sort first.
Show fix
Suggested change
| + " p.teamId = :teamId) order by coalesce(p.sortOrder, 0) asc, p.id asc") | |
| List<PolicyEntity> findByTeam(@Param("teamId") Long teamId); | |
| /** All policies in run order — used when team scoping is off (login-disabled). */ | |
| @Query("select p from PolicyEntity p order by coalesce(p.sortOrder, 0) asc, p.id asc") | |
| + " p.teamId = :teamId) order by p.sortOrder nulls first, p.id asc") | |
| List<PolicyEntity> findByTeam(@Param("teamId") Long teamId); | |
| /** All policies in run order — used when team scoping is off (login-disabled). */ | |
| @Query("select p from PolicyEntity p order by p.sortOrder nulls first, p.id asc") |
Details
✨ AI Reasoning
The code is trying to define stable run ordering for team policies and documents that policies with no sort value come first. However, the ordering expression converts null to 0 before sorting. That means records with null and records with sortOrder = 0 are treated identically and then ordered only by id, so null-valued rows are not guaranteed to come first. This creates a concrete mismatch between the stated behavior and actual query semantics.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
dosubot
Bot
added
size:M
Ludy87
marked this pull request as draft
July 9, 2026 17:06
Remove unnecessary @repository annotations and corresponding unused imports from proprietary JPA repository interfaces. Files updated: ResourceGrantRepository, TeamLabelsRepository, ProcessedFileRepository, PolicyRepository, TeamMembershipRepository. No behavioral change — Spring Data auto-detects JpaRepository interfaces; this is a cleanup to remove static noise and unused imports.
Ludy87
marked this pull request as ready for review
July 9, 2026 20:26
Add blank lines between Spring Data imports and domain model imports in three repository classes to improve code organization and readability.
Apply consistent formatting to SaaS repository and configuration classes: - Reflow JavaDoc comment in SaasJpaConfig for line length - Add blank lines after import statements in repository interfaces (Google Java Format style)
stirlingbot
Bot
removed
the
has conflicts
Ludy87
marked this pull request as ready for review
July 26, 2026 16:33
stirlingbot
Bot
added
the
has conflicts
stirlingbot
Bot
added
has conflicts
stirlingbot
Bot
removed
the
has conflicts
stirlingbot
Bot
added
the
has conflicts
stirlingbot
Bot
removed
the
has conflicts
Updates the bundled third-party license metadata to reflect newer dependency versions for Jackson JDK8 and Protobuf, and removes stale entries for renamed or obsolete modules after the dependency refresh.
balazs-szucs
previously approved these changes
Aug 20, 2026
github-actions
Bot
added
the
has conflicts
github-actions
Bot
removed
the
has conflicts
balazs-szucs
approved these changes
Aug 20, 2026
Contributor
✅ Backend License Check PassedAll backend dependencies have valid and allowed licenses. The backend license report has been updated successfully. |
Contributor
🚀 V2 Auto-Deployment Complete!🔗 Direct Test URL (non-SSL) http://54.175.155.236:6930 🧩 Admin portal included - try it at http://54.175.155.236:6930/portal. This deployment will be automatically cleaned up when the PR is closed. 🔄 Auto-deployed for approved V2 contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR removes redundant
@Repositoryannotations from Spring Data JPA repository interfaces and updates several core framework dependencies, primarily upgrading Spring Boot to 4.1.0.What was changed
@Repositoryannotations and related imports from all Spring Data JPA repository interfaces across theproprietaryandsaasmodules.@Repositoryinterfaces".org.apache.santuario:xmlsec:4.0.4com.google.guava:guava:${guavaVersion}getEnv()Gradle helper that logs relevant security and build environment variables during the build process.Why the change was made
JpaRepository, making explicit@Repositoryannotations unnecessary.Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)
task checkto verify linters, typechecks, and tests pass